Enhancement py38 support #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #68 |
This was referenced May 8, 2020
Merged
davidban77
added a commit
that referenced
this pull request
May 8, 2020
* Adding extra tag * Updating pydantic and fixing changelog.md * Refactoring verify_connector_and_id * Fixing formatting * Upload image (#63) * minimal GNS3 version * Added compute image upload method. Co-authored-by: louis-oui <47607835+louis-oui@users.noreply.github.com> * Upgrading to poetry v1.0 (#67) * Enhancement py38 support (#68) * Updating and fixing envlist in tox * Adding tox-conda requirements and changing image on circleci * Fixing step to install poetry * Adding python 3.8 in classifiers * Enhancement docker dev environment (#69) * Adding devcontainer for vscode standardized testing * Fixing the project close method update and wrap docstring * fixing tests and adding some docs (#72) Co-authored-by: Scott Keiffer <eskeiffer@gmail.com> Co-authored-by: louis-oui <47607835+louis-oui@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
condato manage the python environments. So added thetox-condaplugin requirement which will be triggered when running thetoxcommand.Also changed the CircleCI image to
continuumio/miniconda3to handle the python environments.