Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add s1 indices #287

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

felixlobert
Copy link

  • adding the S1 Radar Vegetation Index (RVI) and the S1 backscatter cross-ratio to the list of available spectral indices

@felixlobert felixlobert marked this pull request as draft May 10, 2023 12:28
@@ -31,6 +31,8 @@ This file contains functions for computing spectral indices
#include "gsl/gsl_blas.h"
#include "gsl/gsl_linalg.h"

#include <math.h>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better put in *.h file

@davidfrantz
Copy link
Owner

Hi Felix,

thanks for the contribution. However, the checks were not successful. There seem to be some syntax errors.
Please also take a look at the comment with the math include.

In addition, please be aware that there is a working branch under development, which may cause merge conflicts at a later stage: https://github.com/davidfrantz/force/tree/external_tables
However, as I currently don't have time to work on this branch, this should not be a reason to not accept your PR at this time.
Nevertheless, the routines for computing indices will change in the future as there will be an external table that defines wavelengths for each index.

Cheers,
David

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants