-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for AppSync DataSource invocations #144
Conversation
It looks great, thank you very much for your contribution! I'd like to ask for a minor request before merging it though, could you add integration tests? To do that, you only need to add the appropriate |
Hey man will get on that, thanks. I think I'll need to use |
I'm not familiar with AppSync, but if it's not supported by the Serverless framework yeah, you'll most likely have to use |
Hey @davidgf, added integration tests as requested, I'm not sure what you mean by updating the example bit, as this should just work with AppSync DataSources? |
@davidgf hey mate, any updates on this when you get a chance please? Cheers |
Hey @bendubuisson, first of all, I'm very sorry for the delay, but my professional commitments are keeping me quite busy. By examples I mean that there is an example folder in this repository, which includes a serverless application with a function that is triggered by all the event sources supported by this plugin and all the necessary AWS resources. This helps me testing the new functionality and serves as an example for anyone using the plugin. I'd be very grateful if you could extend the example to test the AppSync trigger, but I'm merging the PR anyway |
Hey @davidgf, don't be sorry, I perfectly understand! Thank you for the hard work and I'll look into your request! Cheers |
Proposed changes
This adds support for AppSync DataSources. Tested with the serverless-appsync-plugin plugin.
Types of changes
Checklist
Further comments
I had to change the lifecycle hook we use as the plugin adding DataSources (mentioned earlier) happens later in the cycle, so the DataSources weren't in the CF template yet... Let me know if you think it will be a problem?