-
-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report coverage #863
Report coverage #863
Conversation
Codecov Report
@@ Coverage Diff @@
## master #863 +/- ##
=========================================
Coverage ? 22.99%
=========================================
Files ? 2
Lines ? 574
Branches ? 112
=========================================
Hits ? 132
Misses ? 433
Partials ? 9
Continue to review full report at Codecov.
|
7bffa8d
to
e3d37d1
Compare
For some reason py2 is not working: https://travis-ci.org/davidhalter/jedi-vim/jobs/409612945
|
Found it:
A Coverage.py warning apparently causes pytest to not detect py2 correctly.. :/ |
20.9% coverage.. \o/ Needs some cleanup, but should be good then already (let's get the branches/PRs it depends on though in anyway). Next step would be covimerage to track coverage for the Vimscript part. |
Acutally > 25% (flags were broken). Something looks a bit odd, e.g. https://codecov.io/gh/davidhalter/jedi-vim/src/ce0d16a4dfafdcd92bae67475dcd0d2b5b6fabae/pythonx/jedi_vim.py#L166 (is there an exception/error happening?). |
Should be good, but I want to cleanup/review it myself once more. |
I like it! ;) Should be squash-merged (I can do it). |
I'll just put you in charge for this. :) I like that we have coverage and don't really care how it's exactly done! |
Yeah! \o/ |
TODO:
Includes/rebased on #864 for now.