use sys.executable() standard function to obtain python executable
#1964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `sys.executable()` standard function instead custom code which assumes that python executable is `python`. Signed-off-by: Tomasz Kłoczko <kloczek@github.com>
Codecov ReportAll modified lines are covered by tests ✅ ❗ Your organization needs to install the Codecov GitHub app to enable full functionality. 📢 Thoughts on this report? Let us know!. |
|
The tests are failing unfortunately. If this works well, I'm happy to merge it, but not as long as the tests fail. |
Looks like it fails in one env in custom code which is trying to figure out what is the sitelib path (which should be obtained from |
|
Closing, because I don't think there is progress here (and I'm pretty sure that this might break in some cases). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
sys.executable()standard function instead custom code which assumes that python executable ispython.