Removed 'px' replace on parseInt (not needed), plus did a build

davidjbradshaw · Oct 16, 2019 · c32bdc7 · c32bdc7
1 parent 16b486c
commit c32bdc7
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 11 deletions.
diff --git a/js/iframeResizer.contentWindow.min.js b/js/iframeResizer.contentWindow.min.js
diff --git a/js/iframeResizer.js b/js/iframeResizer.js
@@ -168,7 +168,6 @@
     }
 
     function getPaddingEnds(compStyle) {
-
       if (compStyle.boxSizing !== 'border-box') {
         return 0;
       }
@@ -181,8 +180,8 @@
       if (compStyle.boxSizing !== 'border-box') {
         return 0;
       }
-      var top = compStyle.borderTopWidth && compStyle.borderTopWidth.indexOf('px') !== -1 ? parseInt(compStyle.borderTopWidth.replace('px', ''), 10) : 0
-      var bot = compStyle.borderBottomWidth && compStyle.borderBottomWidth.indexOf('px') !== -1 ? parseInt(compStyle.borderBottomWidth.replace('px', ''), 10) : 0
+      var top = compStyle.borderTopWidth ? parseInt(compStyle.borderTopWidth, 10) : 0
+      var bot = compStyle.borderBottomWidth ? parseInt(compStyle.borderBottomWidth, 10) : 0
       return top + bot
     }
 

diff --git a/js/iframeResizer.map b/js/iframeResizer.map
diff --git a/js/iframeResizer.min.js b/js/iframeResizer.min.js
diff --git a/src/iframeResizer.js b/src/iframeResizer.js
@@ -171,17 +171,17 @@
       if (compStyle.boxSizing !== 'border-box') {
         return 0;
       }
-      var top = compStyle.paddingTop ? parseInt(compStyle.paddingTop.replace('px', ''), 10) : 0
-      var bot = compStyle.paddingBottom ? parseInt(compStyle.paddingBottom.replace('px', ''), 10) : 0
+      var top = compStyle.paddingTop ? parseInt(compStyle.paddingTop, 10) : 0
+      var bot = compStyle.paddingBottom ? parseInt(compStyle.paddingBottom, 10) : 0
       return top + bot
     }
 
     function getBorderEnds(compStyle) {
       if (compStyle.boxSizing !== 'border-box') {
         return 0;
       }
-      var top = compStyle.borderTopWidth ? parseInt(compStyle.borderTopWidth.replace('px', ''), 10) : 0
-      var bot = compStyle.borderBottomWidth ? parseInt(compStyle.borderBottomWidth.replace('px', ''), 10) : 0
+      var top = compStyle.borderTopWidth ? parseInt(compStyle.borderTopWidth, 10) : 0
+      var bot = compStyle.borderBottomWidth ? parseInt(compStyle.borderBottomWidth, 10) : 0
       return top + bot
     }