Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat]: Add robust pinch zoom support #830

Merged
merged 1 commit into from
Apr 29, 2024
Merged

[Feat]: Add robust pinch zoom support #830

merged 1 commit into from
Apr 29, 2024

Conversation

dravenkickass
Copy link
Contributor

@dravenkickass dravenkickass commented Apr 19, 2024

@davidjerleke davidjerleke changed the title Add robust pinch zoom support [Feat]: Add robust pinch zoom support Apr 19, 2024
@davidjerleke
Copy link
Owner

@realwagyu thank you for your contribution 👍. I will review this when possible. Thanks for your patience.

Best,
David

@davidjerleke davidjerleke added feature request New feature or request core This is related to the core package labels Apr 22, 2024
Copy link
Owner

@davidjerleke davidjerleke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great initiative 👍!

I have two change requests and would very much appreciate if you could test it on an Android device to make sure it behaves like expected.

  1. See code comment.
  2. Let's add pinch-zoom here in the code so it gets applied to all example carousels in the docs:
- const panDirection = `pan-${horizontal ? 'y' : 'x'}`
+ const panDirection = `pan-${horizontal ? 'y' : 'x'} pinch-zoom`

Thanks in advance!

packages/embla-carousel/src/components/DragHandler.ts Outdated Show resolved Hide resolved
@davidjerleke davidjerleke added the awaiting response Issue is awaiting feedback label Apr 27, 2024
@davidjerleke davidjerleke removed the awaiting response Issue is awaiting feedback label Apr 28, 2024
@davidjerleke davidjerleke added the resolved This issue is resolved label Apr 29, 2024
@davidjerleke davidjerleke merged commit 197399d into davidjerleke:master Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core This is related to the core package feature request New feature or request resolved This issue is resolved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants