This repository has been archived by the owner on Aug 23, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 252
Controls with debounce prop call change action after actions.reset when within componentWillUnmount #951
Comments
@davidkpiano thanks for the quick fix but for some reason it doesnt seem that the fix has landed in 1.14.2 https://unpkg.com/react-redux-form@1.14.2/lib/utils/debounce.js the above debounce in the lib directory doesnt seem to have the fix and i pulled it down locally with the same issue |
@davidkpiano can we maybe bump to 1.14.3 to ensure all new version have this fixed? |
@davidchase I'll bump a new patch either today or tomorrow. |
Ok thanks 👍🏻 |
Just checking back in on this, has a new patch been released? |
@lstuartfry yes it looks like the latest version has patch and check the codepen 👆 looks like it works 😄 |
@davidchase thanks for the update! |
peterox
pushed a commit
to peterox/react-redux-form
that referenced
this issue
Oct 26, 2017
peterox
added a commit
to peterox/react-redux-form
that referenced
this issue
Oct 26, 2017
…avidkpiano#951 davidkpiano#884" This reverts commit dd333e5.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The Problem
If a control has a debounce prop and the field has a value, calling action.reset on componentWillUnmount will first clear
the model and field and then call change again populating the field and model with previous value.
This is basically issue #884 but since i cannot reopen the issue i thought i would create a new since its still a bug in latest version.
The original OP's codepen can be used to view the bug https://codepen.io/lstuartfry/pen/Pjvwrq
Let me know if i should create a PR with a fix
Thanks :)
The text was updated successfully, but these errors were encountered: