Skip to content

Commit

Permalink
chore: update links angular.io -> angular.dev (#606)
Browse files Browse the repository at this point in the history
  • Loading branch information
davidlj95 authored May 24, 2024
1 parent b0733a1 commit 8d2e519
Show file tree
Hide file tree
Showing 10 changed files with 18 additions and 12 deletions.
3 changes: 2 additions & 1 deletion projects/ngx-meta/api-extractor/tsconfig.api-extractor.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
/* To learn more about this file see: https://angular.io/config/tsconfig. */
/* To learn more about Typescript configuration file see: https://www.typescriptlang.org/docs/handbook/tsconfig-json.html
For Angular-specific options: https://angular.dev/reference/configs/angular-compiler-options */
{
"extends": "../src/tsconfig.lib.json",
"compilerOptions": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ export class BlogModule {}

If you migrated to standalone apps, where need for Angular modules is reduced, you may have followed [Angular's guide about lazy loading in standalone apps]

[Angular's guide about lazy loading in standalone apps]: https://angular.io/guide/standalone-components#routing-and-lazy-loading
[Angular's guide about lazy loading in standalone apps]: https://v16.angular.io/guide/standalone-components#routing-and-lazy-loading

In there, to lazy load a route, you either dynamically import a component or many routes. If you dynamically import a component, check out next chapter about [adding a metadata module in a component](#component). Otherwise, keep reading.

Expand Down
2 changes: 1 addition & 1 deletion projects/ngx-meta/docs/includes/common-links.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,4 @@
[Twitter Cards module]: /built-in-modules/twitter-cards/
[bundle size issue]: https://github.com/davidlj95/ngx/issues/112
[tree shaking]: https://developer.mozilla.org/en-US/docs/Glossary/Tree_shaking
[Angular actively supported versions]: https://angular.io/guide/releases#actively-supported-versions
[Angular actively supported versions]: https://angular.dev/reference/releases#actively-supported-versions
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,9 @@ export const NAVIGATION_END_EVENT_TYPE = new NavigationEnd(0, '', '').type

@Injectable({ providedIn: 'root' })
export class NgxMetaRouterListenerService implements OnDestroy {
// Replace by `takeUntilDestroyed` when stable
// https://angular.io/api/core/rxjs-interop/takeUntilDestroyed
// Replace by `takeUntilDestroyed` when stable & oldest Angular supported version is v16 where it was introduced
// https://angular.dev/api/core/rxjs-interop/takeUntilDestroyed
// https://github.com/angular/angular/commit/e8831984601da631afc29f9fd72d36f57696f936
private sub?: Subscription

constructor(
Expand Down
3 changes: 2 additions & 1 deletion projects/ngx-meta/src/tsconfig.lib.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
/* To learn more about this file see: https://angular.io/config/tsconfig. */
/* To learn more about Typescript configuration file see: https://www.typescriptlang.org/docs/handbook/tsconfig-json.html
For Angular-specific options: https://angular.dev/reference/configs/angular-compiler-options */
{
"extends": "../../../tsconfig.json",
"compilerOptions": {
Expand Down
3 changes: 2 additions & 1 deletion projects/ngx-meta/src/tsconfig.lib.prod.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
/* To learn more about this file see: https://angular.io/config/tsconfig. */
/* To learn more about Typescript configuration file see: https://www.typescriptlang.org/docs/handbook/tsconfig-json.html
For Angular-specific options: https://angular.dev/reference/configs/angular-compiler-options */
{
"extends": "./tsconfig.lib.json",
"compilerOptions": {
Expand Down
3 changes: 2 additions & 1 deletion projects/ngx-meta/src/tsconfig.spec.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
/* To learn more about this file see: https://angular.io/config/tsconfig. */
/* To learn more about Typescript configuration file see: https://www.typescriptlang.org/docs/handbook/tsconfig-json.html
For Angular-specific options: https://angular.dev/reference/configs/angular-compiler-options */
{
"extends": "../../../tsconfig.json",
"compilerOptions": {
Expand Down
2 changes: 1 addition & 1 deletion projects/ngx-meta/src/types/angular.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ declare global {
/**
* Used to know if we're in dev mode, in the same fashion Angular does
*
* Public API `isDevMode` (https://angular.io/api/core/isDevMode) is more
* Public API `isDevMode` (https://angular.dev/api/core/isDevMode) is more
* stable. However, given it's a function call, code under `if(isDevMode())`
* can not tree-shaken. So to allow tree-shaking, using a `const` in the
* same fashion Angular does for their packages. Simplifying the type to be
Expand Down
4 changes: 2 additions & 2 deletions renovate.json5
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,8 @@
automerge: true,
},
// Angular v17.3.x compatibilities
// https://angular.io/guide/versions
// https://update.angular.io/?v=16.0-17.0 (zone.js)
// https://angular.dev/reference/versions
// https://angular.dev/update-guide?v=16.0-17.0&l=1
{
matchDepPrefixes: ['@angular'],
matchFileNames: ['package.json'],
Expand Down
3 changes: 2 additions & 1 deletion tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
/* To learn more about this file see: https://angular.io/config/tsconfig. */
/* To learn more about Typescript configuration file see: https://www.typescriptlang.org/docs/handbook/tsconfig-json.html
For Angular-specific options: https://angular.dev/reference/configs/angular-compiler-options */
{
"compileOnSave": false,
"compilerOptions": {
Expand Down

0 comments on commit 8d2e519

Please sign in to comment.