refactor: rename selected -> isSelected

davidlj95 · Nov 27, 2024 · d88edb6 · d88edb6
1 parent babd22b
commit d88edb6
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 15 deletions.
diff --git a/src/app/resume-page/chip/chip.component.spec.ts b/src/app/resume-page/chip/chip.component.spec.ts
@@ -66,7 +66,7 @@ describe('ChipComponent', () => {
     beforeEach(() => {
       ;[fixture, component] = componentTestSetup(ChipComponent)
       fixture.componentRef.setInput('selected', false)
-      subscription = component.selectedChange
+      subscription = component.isSelectedChange
         .pipe(first())
         .subscribe((isSelectedReceived) => (isSelected = isSelectedReceived))
       fixture.detectChanges()

diff --git a/src/app/resume-page/chip/chip.component.ts b/src/app/resume-page/chip/chip.component.ts
@@ -6,22 +6,22 @@ import { Component, EventEmitter, input, Output } from '@angular/core'
   styleUrls: ['./chip.component.scss'],
   standalone: true,
   host: {
-    '[class.selected]': 'selected()',
-    '[class.selectable]': 'selectedChange.observed',
-    '[attr.role]': "selectedChange.observed ? 'button': undefined",
-    '[attr.tabindex]': 'selectedChange.observed ? 0 : undefined',
+    '[class.selected]': 'isSelected()',
+    '[class.selectable]': 'isSelectedChange.observed',
+    '[attr.role]': "isSelectedChange.observed ? 'button': undefined",
+    '[attr.tabindex]': 'isSelectedChange.observed ? 0 : undefined',
     '(click)': 'emitToggledSelected()',
     '(keydown.enter)': 'emitToggledSelected()',
     '(keydown.space)': 'emitToggledSelected()',
   },
 })
 export class ChipComponent {
-  readonly selected = input<boolean>()
+  readonly isSelected = input<boolean>()
 
   @Output()
-  selectedChange = new EventEmitter<boolean>()
+  isSelectedChange = new EventEmitter<boolean>()
 
   protected emitToggledSelected() {
-    this.selectedChange.emit(!this.selected())
+    this.isSelectedChange.emit(!this.isSelected())
   }
 }
diff --git a/src/app/resume-page/chipped-content/chipped-content.component.html b/src/app/resume-page/chipped-content/chipped-content.component.html
@@ -1,8 +1,8 @@
 <div class="chips">
   @for (content of contents(); track content) {
     <app-chip
-      [selected]="isActive() && content === activeContent()"
-      (selectedChange)="select(content)"
+      [isSelected]="isActive() && content === activeContent()"
+      (isSelectedChange)="select(content)"
     >
       {{ content.displayName }}
     </app-chip>

diff --git a/src/app/resume-page/chipped-content/chipped-content.component.spec.ts b/src/app/resume-page/chipped-content/chipped-content.component.spec.ts
@@ -41,7 +41,7 @@ describe('ChippedContentComponent', () => {
     chipElements.forEach((chipElement, index) => {
       const content = CONTENTS[index]
 
-      expect(getComponentInstance(chipElement, ChipComponent).selected())
+      expect(getComponentInstance(chipElement, ChipComponent).isSelected())
         .withContext(`chip ${index} is unselected`)
         .toBeFalse()
 
@@ -100,7 +100,7 @@ describe('ChippedContentComponent', () => {
 
     it('should mark the chip as selected', () => {
       expect(
-        getComponentInstance(firstChipElement, ChipComponent).selected(),
+        getComponentInstance(firstChipElement, ChipComponent).isSelected(),
       ).toBe(true)
     })
 
@@ -126,7 +126,7 @@ describe('ChippedContentComponent', () => {
 
       it('should mark the chip as unselected', () => {
         expect(
-          getComponentInstance(firstChipElement, ChipComponent).selected(),
+          getComponentInstance(firstChipElement, ChipComponent).isSelected(),
         ).toBeFalse()
       })
 
@@ -152,11 +152,11 @@ describe('ChippedContentComponent', () => {
 
       it('should mark the previous chip as unselected and just tapped chip as selected', () => {
         expect(
-          getComponentInstance(firstChipElement, ChipComponent).selected(),
+          getComponentInstance(firstChipElement, ChipComponent).isSelected(),
         ).toBeFalse()
 
         expect(
-          getComponentInstance(secondChipElement, ChipComponent).selected(),
+          getComponentInstance(secondChipElement, ChipComponent).isSelected(),
         ).toBeTrue()
       })