Escape __dirname before generating regexp #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BridgeAR
approved these changes
Oct 19, 2018
goto-bus-stop
approved these changes
Oct 19, 2018
|
|
||
| const preloadDirRx = RegExp(join(__dirname, 'preload')) | ||
| const preloadDirRx = RegExp(join(escape(__dirname), 'preload')) |
There was a problem hiding this comment.
This won't escape windows-path\preload, but I don't think that's a problem… escape(join()) would make sure the entire thing is escaped, regardless
Suggested change
| const preloadDirRx = RegExp(join(escape(__dirname), 'preload')) | |
| const preloadDirRx = RegExp(escape(join(__dirname, 'preload'))) |
There was a problem hiding this comment.
Actually escaping before joining does introduce more backslashes which may be a problem for unicodey windows paths or network drives? I'm not really familiar with them, just know that there's a bunch of \\?\\whatever going on.
There was a problem hiding this comment.
escaping after joining does not work. I tried that first.
There was a problem hiding this comment.
Ah, that's unintuitive. Alright 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #190