Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: collect-only to render-only flow #253

Merged
merged 1 commit into from
Feb 21, 2022

Conversation

adiktofsugar
Copy link
Contributor

In v8-log-to-ticks.js:152

const delayMs = options.collectDelay * 1000
...
// Compare ticks to first for collectDelay
if (tick.tm > (firstTick[0] + delayMs)) {
  ticks.push(stack.reverse())
}

But without this change, collectDelay is NaN so firstTick[0] + NaN ends up NaN, which always returns false when compared to a number, so this never resolves to true, and no ticks get added.

Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 7b46b77 into davidmarkclements:master Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants