Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status endpoints #8

Merged

Conversation

gbhanda
Copy link

@gbhanda gbhanda commented Feb 18, 2022

Description

Added status method whose GET method gives vip_identity of all the agents with their priority, name, uuid, running status, enable status ,and tag and whose DELETE method clears all the running status.
Also added agent/status method whose GET method gives priority, name, uuid, running status, enable status ,and tag of a particular agent.
Additionally there are test for all those method

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • [ ✓] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
The tests are in the /volttron/volttrontesting/platform/web/test_vui_endpoints.py
For handle_platforms_agents_status
Run test_handle_platforms_agents_status_status_code to check the status code
Run test_handle_platforms_agents_status_get_response to check the GET request's functionality.
For handle_platforms_status
Run test_handle_platforms_status_status_code to check the status code
Run test_handle_platforms_status_get_response to check the GET request's functionality.
Run test_handle_platforms_status_delete_response to check the DELETE request's functionality.

  • Test A
  • Test B

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • [ ✓] My code follows the style guidelines of this project
  • [ ✓ I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [ ✓] My changes generate no new warnings
  • [ ✓] I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@gbhanda gbhanda changed the base branch from develop to vui_current_state_rebased February 18, 2022 02:19
@davidraker
Copy link
Owner

davidraker commented Feb 18, 2022

First off, this looks good, and looks like it should work. You haven't included your tests in the pull request, though. Please commit the test_vui_endpoints file and push it. I do also think we can simplify the helper function a bit as well (this will work, but I think we can do a bit less processing to achieve the same effect). I want to take a closer look at it when I get back to my computer tomorrow, then we can discuss that part.

@davidraker davidraker merged commit 2526878 into davidraker:vui_current_state_rebased Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants