forked from astral-sh/ruff
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proper f string formatting 5 #1
Draft
davidszotten
wants to merge
23
commits into
joined-string-part
Choose a base branch
from
proper-f-string-formatting-5
base: joined-string-part
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR Check ResultsBenchmarkLinux
Windows
|
davidszotten
force-pushed
the
joined-string-part
branch
from
August 26, 2023 13:33
ab9b96c
to
606e185
Compare
davidszotten
force-pushed
the
joined-string-part
branch
from
August 27, 2023 07:32
606e185
to
65030af
Compare
davidszotten
force-pushed
the
proper-f-string-formatting-5
branch
from
August 27, 2023 07:35
583638b
to
22bbf3b
Compare
davidszotten
force-pushed
the
proper-f-string-formatting-5
branch
from
August 27, 2023 07:42
22bbf3b
to
cbb5c64
Compare
davidszotten
force-pushed
the
joined-string-part
branch
from
August 28, 2023 10:41
65030af
to
cdebe7c
Compare
davidszotten
force-pushed
the
joined-string-part
branch
3 times, most recently
from
September 24, 2023 07:37
5907914
to
d9fdd3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
WIP proper f-string formatting (formatting inside f-strings)
note that black doesn't (yet?) do this so adding this is likely to decrease the similarity index scores (see eg diffs in the existing snapshots)
Test Plan
snapshots