Add option to select which browser playwright uses #1129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emuwakwe
approved these changes
Mar 30, 2024
|
|
LGTM |
davidteather
added a commit
that referenced
this pull request
Apr 12, 2024
* Add 'executable_path' field to the 'api.create_sessions()' method (#1136) * Fixed retries loop (#1133) * Add option to select which browser playwright uses (#1129) * add browser selection option to create_sessions method * fix spelling typo --------- Co-authored-by: David Teather <34144122+davidteather@users.noreply.github.com> * Update hashtag.py (#1126) TikTok appears to have limited the number of posts that can be returned for a single hashtag search to 35 (e.g. bellingcat/tiktok-hashtag-analysis#28). Similar to how the `User.liked` method works, I set the batch size to 35 videos per request. * add executable path to str * bump ver --------- Co-authored-by: kkordik <99617240+Kkordik@users.noreply.github.com> Co-authored-by: ekorian <korian.edeline@gmail.com> Co-authored-by: Will Howes <39531537+willmhowes@users.noreply.github.com> Co-authored-by: Tristan Lee <tristan@bellingcat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addition is purely motivated by the fact that I was able to circumvent the #1116 headless mode error by using firefox instead of the default chromium browser which currently throws errors. I am new the project and don't know the motivations behind using chromium as the default, which does still work in headed mode, so I added the option to select the browser rather than changing any default behavior.
My testing has been limited, but I haven't found any library behavior broken by using firefox instead of chromium.