Fix ci-build status badge and link status badge to actions #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The URL format didn't match the [currently documented badge URL](https://docs.github.com/en/actions/monitoring-and-troubleshooting-workflows/monitoring-workflows/adding-a-workflow-status-badge#using-the-branch-parameter).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
The ci-build status badge on README.md is showing no status, even though the action recently ran successfully.
The status badge was added 4 years ago, so I'm guessing GitHub made a breaking change since then, though I found no documentation to confirm this. I suspect the problem is some GitHub edge case related to the name of the yaml file being
ci_build.ymlbut the name of the action beingci-build.Changes
Testing
status badge
Before change:
After change:
clicking on badge
Before change, clicking on badge takes you to https://github.com/davidtvs/pytorch-lr-finder/workflows/ci-build/badge.svg?branch=master
After change, clicking on badge takes you to: https://github.com/davidtvs/pytorch-lr-finder/actions/workflows/ci_build.yml?query=branch%3Amaster