pull out anonymous functions in groupByKey

davies · Feb 8, 2015 · f5038c0 · f5038c0
1 parent ba6f044
commit f5038c0
Showing 1 changed file with 10 additions and 9 deletions.
diff --git a/pkg/R/RDD.R b/pkg/R/RDD.R
@@ -1383,20 +1383,21 @@ setMethod("groupByKey",
               vals <- new.env()
               keys <- new.env()
               pred <- function(item) exists(item$hash, keys)
+              appendList <- function(acc, x) {
+                addItemToAccumulator(acc, x)
+                acc
+              }
+              makeList <- function(x) {
+                acc <- initAccumulator()
+                addItemToAccumulator(acc, x)
+                acc
+              }
               # Each item in the partition is list of (K, V)
               lapply(part,
                      function(item) {
                        item$hash <- as.character(hashCode(item[[1]]))
                        updateOrCreatePair(item, keys, vals, pred,
-                                          function(acc, x) {
-                                            addItemToAccumulator(acc, x)
-                                            acc
-                                          },
-                                          function(x) {
-                                            acc <- initAccumulator()
-                                            addItemToAccumulator(acc, x)
-                                            acc
-                                          })
+                                          appendList, makeList)
                      })
               # extract out data field
               vals <- eapply(vals,