Fix LTO check on FreeBSD11 #207
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the LTO (link time optimisation) check is done by trying to compile a single object file with the -flto option. This way the check does not cover the case that the compiler supports it but the linker does not. This can happen for instance on FreeBSD11 with FreeBSD clang version 6.0.0 in combination with GNU ld 2.17.50, where the latter does not support the -plugin option. Modify the check by removing the -c flag from the compiler options.
|
@davisp I can't say I fully understand the issue, but I run into this on FreeBSD atm since last clang updates. Can you +1 / merge & tag so we can get this into couchdb git please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the LTO (link time optimisation) check is done by trying
to compile a single object file with the -flto option. This way the
check does not cover the case that the compiler supports it but the
linker does not.
This can happen for instance on FreeBSD11 with FreeBSD clang version
6.0.0 in combination with GNU ld 2.17.50, where the latter does not
support the -plugin option.
Modify the check by removing the -c flag from the compiler options.