feat(comment): Add comment spec for columns #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Columns can have comment if the 'comment' property is set in the column definition. Relates to #558
Columns can have comment if the 'comment' property is set in the column definition. Relates to #558 Signed-off-by: Mike Drakoulelis <mikedrakoulelis@yahoo.gr>
|
I have made the required changes for the column comment, however I cannot make the tests to pass (even in master branch) so I cannot add further tests for comments. It seems that no tables are created, since Also, it might be difficult to check for the existence of comments, since db-meta does not support getting column comment, a separate SQL has to be made in test. I would like some help so that I can implement the required tests, if needed. |
|
I will review this in the next days, should I for some reason do not please ping me @miced |
|
@wzrdtales any update? |
|
Any update on this PR? @wzrdtales |
|
Hey |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Columns can have comment if the 'comment' property is set in the column definition.
Relates to db-migrate/node-db-migrate#558