Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: adapt changes out of release 3.0.0 by DB UI core #2710

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

refactor: adapt changes out of release 3.0.0 by DB UI core #2710

wants to merge 6 commits into from

Conversation

mfranzke
Copy link
Member

@mfranzke mfranzke commented Aug 6, 2024 •
edited
Loading

@mfranzke mfranzke added this to the Release 1.0 milestone Aug 6, 2024
@mfranzke mfranzke self-assigned this Aug 6, 2024
@mfranzke mfranzke linked an issue Aug 6, 2024 that may be closed by this pull request
refactor: adapt changes out of release 3.0.0 by DB UI Core #2709
Open
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 6, 2024

🔭🐙🐈 Test this branch here: https://db-ui.github.io/elements/review/2709-refactor-adapt-changes-out-of-release-300-by-db-ui-core

@mfranzke mfranzke enabled auto-merge (squash) August 6, 2024 10:07
@jonaskuske @mfranzke
fix(chip): remove aria-hidden to expose label in a11y tree (#2659)
cab0794 
Co-authored-by: Maximilian Franzke <787658+mfranzke@users.noreply.github.com>
@nmerget
Copy link
Member

nmerget commented Aug 6, 2024

@mfranzke a test failed

@mfranzke
Copy link
Member Author

mfranzke commented Aug 8, 2024

@mfranzke a test failed

@nmerget could you please update the screenshots for this PR on your environment?

mfranzke
mfranzke commented Aug 8, 2024
View reviewed changes
e2e/cypress/snapshots/base/db-brand.cy.js/db-brand.png
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The clickable sitename doesn't look correct.

@mfranzke mfranzke added the 🪩 🔥 🕺 cool topic some relevant topics, that we even also need to report in different rounds / to stakeholders label Aug 30, 2024
@mfranzke mfranzke mentioned this pull request Nov 4, 2024
Closed
@mfranzke mfranzke mentioned this pull request Nov 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmerget nmerget Awaiting requested review from nmerget nmerget is a code owner

@dkolba dkolba Awaiting requested review from dkolba dkolba is a code owner

@annsch annsch Awaiting requested review from annsch annsch is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@mfranzke mfranzke

@nmerget nmerget

Labels
angular angular-lts-showcase 🪩 🔥 🕺 cool topic some relevant topics, that we even also need to report in different rounds / to stakeholders improvement repo stencil
Projects
None yet
Milestone
Release 1.0
Development

Successfully merging this pull request may close these issues.

refactor: adapt changes out of release 3.0.0 by DB UI Core
3 participants
@mfranzke @nmerget @jonaskuske