Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: tidy-up scripts #2024

Merged
merged 15 commits into from
Mar 7, 2024
Merged

chore: tidy-up scripts #2024

merged 15 commits into from
Mar 7, 2024

Conversation

nmerget
Copy link
Member

@nmerget nmerget commented Jan 4, 2024

Proposed changes

Moved some scripts from root package.json to scripts/package.json to have a better overview.
Most of the scripts are needed because of npm-run-all, as we can't run scripts in parallel on npm workspaces yet.

closes #1541
closes #1958

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

Copy link
Contributor

github-actions bot commented Jan 4, 2024

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/chore-tidy-up-scripts

@nmerget nmerget enabled auto-merge (squash) January 4, 2024 10:14
e2e/README.md Show resolved Hide resolved
@nmerget nmerget requested a review from mfranzke January 4, 2024 11:45
package.json Show resolved Hide resolved
# Conflicts:
#	.github/workflows/02-e2e-showcases.yml
#	.github/workflows/02-e2e.yml
#	e2e/Dockerfile
#	e2e/package-lock.json
#	e2e/package.json
#	package-lock.json
@github-actions github-actions bot added 📕documentation Improvements or additions to documentation 🚢📀cicd Changes inside .github folder 📺showcases Changes to 1-n showcases labels Jan 31, 2024
@nmerget nmerget requested a review from mfranzke January 31, 2024 11:42
@nmerget nmerget assigned mfranzke and unassigned nmerget Jan 31, 2024
@mfranzke
Copy link
Member

mfranzke commented Feb 28, 2024

@nmerget I'm still struggling with "just" moving our scripts to a sub-package. Out of npm/rfcs#190 I found https://github.com/google/wireit – what do you think about that for some consolidation ? To me this solution seems to be simpler than lerna etc. and still near to the standards.

@nmerget
Copy link
Member Author

nmerget commented Feb 28, 2024

@nmerget I'm still struggling with "just" moving our scripts to a sub-package. Out of npm/rfcs#190 I found https://github.com/google/wireit – what do you think about that for some consolidation ? To me this solution seems to be simpler than lerna etc. and still near to the standards.

We can check out https://github.com/google/wireit. But I would recommend doing it in another branch.
This solution is pretty simple without the need for some additional dependency, so we should tidy up the script. At the moment it's just to much inside package.json...

scripts/dev.js Outdated Show resolved Hide resolved
mfranzke
mfranzke previously approved these changes Mar 6, 2024
@nmerget nmerget merged commit 218e715 into main Mar 7, 2024
27 checks passed
@nmerget nmerget deleted the chore-tidy-up-scripts branch March 7, 2024 09:32
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚢📀cicd Changes inside .github folder 📕documentation Improvements or additions to documentation 📺showcases Changes to 1-n showcases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs(e2e): align docs and scripts npm clean scripts
2 participants