Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add new event for tabs #3833

Merged
merged 4 commits into from
Feb 20, 2025
Merged

feat: add new event for tabs #3833

merged 4 commits into from
Feb 20, 2025

Conversation

nmerget
Copy link
Collaborator

@nmerget nmerget commented Feb 18, 2025 •
edited
Loading

Proposed changes

closes #3548

Add onIndexChange and onTabSelect for DBTab

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@nmerget nmerget enabled auto-merge (squash) February 18, 2025 16:04
@github-actions GitHub Actions
Copy link
Contributor

🔭🐙🐈 Test this branch here: https://db-ux-design-system.github.io/core-web/review/feat-tab-selected

@github-actions github-actions bot added the 🏘components Changes inside components folder label Feb 18, 2025
@nmerget nmerget changed the title feat: add new event for tab-list feat: add new event for tabs Feb 19, 2025
@nmerget nmerget disabled auto-merge February 20, 2025 10:50
@nmerget nmerget merged commit ef95233 into main Feb 20, 2025
73 checks passed
@nmerget nmerget deleted the feat-tab-selected branch February 20, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfranzke mfranzke Awaiting requested review from mfranzke mfranzke is a code owner

@annsch annsch Awaiting requested review from annsch

Assignees
No one assigned
Labels
🏘components Changes inside components folder
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DBTabs Missing props
1 participant
@nmerget