Do not crash repr on partially constructed job (#569)

dbader · Apr 9, 2023 · 3863eff · 3863eff
1 parent a3ecd35
commit 3863eff
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/schedule/__init__.py b/schedule/__init__.py
@@ -292,9 +292,13 @@ def is_repr(j):
             job_func_name = self.job_func.__name__
         else:
             job_func_name = repr(self.job_func)
-        args = [repr(x) if is_repr(x) else str(x) for x in self.job_func.args]
-        kwargs = ["%s=%s" % (k, repr(v)) for k, v in self.job_func.keywords.items()]
-        call_repr = job_func_name + "(" + ", ".join(args + kwargs) + ")"
+
+        if self.job_func is not None:
+            args = [repr(x) if is_repr(x) else str(x) for x in self.job_func.args]
+            kwargs = ["%s=%s" % (k, repr(v)) for k, v in self.job_func.keywords.items()]
+            call_repr = job_func_name + "(" + ", ".join(args + kwargs) + ")"
+        else:
+            call_repr = "[None]"
 
         if self.at_time is not None:
             return "Every %s %s at %s do %s %s" % (

diff --git a/test_schedule.py b/test_schedule.py
@@ -661,6 +661,10 @@ def job_fun():
             )
         )
 
+        # Ensure Job.__repr__ does not throw exception on a partially-composed Job
+        s3 = repr(schedule.every(10))
+        assert s3 == "Every 10 None do [None] (last run: [never], next run: [never])"
+
     def test_to_string_lambda_job_func(self):
         assert len(str(every().minute.do(lambda: 1))) > 1
         assert len(str(every().day.at("10:30").do(lambda: 1))) > 1