Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async await #1

Closed
wants to merge 4 commits into from
Closed

Async await #1

wants to merge 4 commits into from

Conversation

ctaggart
Copy link

Some help with OpenAPITools#4210

This may take a while. The next issue has something to do with async_trait:

42 | #[async_trait]
   | ^^^^^^^^^^^^^^ `std::rc::Rc<apis::configuration::Configuration>` cannot be shared between threads safely
   |
   = help: within `apis::tenant_api::TenantApiClient`, the trait `std::marker::Sync` is not implemented for `std::rc::Rc<apis::configuration::Configuration>`

I'll probably investigate more tomorrow. This can be merged as is if you want.

@ctaggart
Copy link
Author

Looks like @srenauld solved this already in OpenAPITools#4175
https://github.com/OpenAPITools/openapi-generator/pull/4175/files#diff-7e03999fbf48b029588e3a360f6a27abR39

Due to the requirement that all futures should be Send, the reference-counting pointer is now an Arc

I'll port that change and try it out tomorrow.

@ctaggart ctaggart closed this Nov 18, 2019
@ctaggart ctaggart deleted the async-await branch March 16, 2020 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant