Fixed broken unit tests: test_mssqlcliclient.py and test_completion_refresher.py #258
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed broken unit tests (
test_mssqlcliclient.py
andtest_completion_refresher.py
)Failed unit tests in
test_mssqlcliclient.py
client.get_views()
failed to retrieve list of views since it uses query with where clauseWHERE table_type = 'View'
that returns nothing on case-sensitive databaseINFORMATION_SCHEMA.VIEWS
instead ofINFORMATION_SCHEMA.TABLES
Failed unit tests in
test_completion_refresher.py
test_ctor
refresher.refreshers.keys()
returns only 5 refresher names defined incompletion_refresher.py
set
comparison should have been used instead oflist
comparison to verify if all elements ofA
are inB
and all elements ofB
are inA
expected_handlers
with appropriate refreshersset
comparison instead oflist
test_refresh_with_callbacks
mssqlcliclient
which blows up whenmssqlcliclient.connect_to_database()
is called.mssqlcliclient
withconnect_to_database()
implementation.Changed use unit test framework
unittest
since class type unit test that extends unittest.TestCase (such as test_mssqlcliclient.py) are a lot more convenient to run and manage.