Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed broken unit test 'test_main.py' and changed test_fuzzy_completion.py to use unittest framework #259

Merged
merged 2 commits into from
Jul 30, 2019

Conversation

geleems
Copy link

@geleems geleems commented Jul 30, 2019

Fixed broken unit test 'test_main.py'
Failed unit tests in test_main.py:

  • test_history_file_not_store_credentials

    • Cause:
      • file_history object does not have append() method but append_string()
      • file_history object is not collection type so len(file_history) fails.
  • test_missing_rc_dir

    • Cause:
      • Wong method was used for building filepath --> str(tmpdir.join("subdir").join("rcfile"))

Changed test_fuzzy_completion.py to use unittest framework

@geleems geleems requested a review from pensivebrian July 30, 2019 00:16
@geleems geleems self-assigned this Jul 30, 2019
@geleems geleems changed the title Fixed broken unit test 'test_main.py' Fixed broken unit test 'test_main.py' and changed test_fuzzy_completion.py to use unittest framework Jul 30, 2019
@geleems geleems changed the title Fixed broken unit test 'test_main.py' and changed test_fuzzy_completion.py to use unittest framework Fixed broken unit test 'test_main.py' and changed test_fuzzy_completion.py to use unittest framework Jul 30, 2019
@geleems geleems merged commit 8223ae9 into master Jul 30, 2019
@geleems geleems deleted the gelee/af branch July 30, 2019 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants