Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed broken unit tests in 'test_sqlcompletion.py' and made non-class type unit tests into class type #261

Merged
merged 2 commits into from
Aug 7, 2019

Conversation

geleems
Copy link

@geleems geleems commented Aug 7, 2019

  • test_json_rpc_contracts.py
    • Renamed get_test_baseline() into get_baseline() since it was recognized as a unit test case by unit test auto discovery
  • tables.py
    • raise StopIteration was used previously, which is ok in Python2 but not in Python3. StopIteration is converted to RuntimeError, and raise StopIteration throws exception in Python3. This broke several unit tests in test_sqlcompletion.py running in Python3. Proper way for backward compatibility is using return statement. (https://www.python.org/dev/peps/pep-0479/)
  • test_prioritization.py and test_rowlimit.py
    • Converted into class type unit tests
  • test_sqlcompletion.py
    • Fixed broken unit tests caused by StopIteration RuntimeError in Python3
    • Fixed broken unit test that was disabled: test_sub_select_multiple_col_name_completion
    • Converted into class type unit tests

All tests are passed in both Python2 and 3.

@geleems geleems requested a review from pensivebrian August 7, 2019 01:49
@geleems geleems self-assigned this Aug 7, 2019
Copy link
Member

@pensivebrian pensivebrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@geleems geleems merged commit bb5c459 into master Aug 7, 2019
@geleems geleems deleted the gelee/row branch August 7, 2019 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants