Fixed broken unit tests in 'test_sqlcompletion.py' and made non-class type unit tests into class type #261
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_test_baseline()
intoget_baseline()
since it was recognized as a unit test case by unit test auto discoveryraise StopIteration
was used previously, which is ok in Python2 but not in Python3.StopIteration
is converted toRuntimeError
, andraise StopIteration
throws exception in Python3. This broke several unit tests in test_sqlcompletion.py running in Python3. Proper way for backward compatibility is usingreturn
statement. (https://www.python.org/dev/peps/pep-0479/)StopIteration
RuntimeError in Python3All tests are passed in both Python2 and 3.