Added localization framework to mssql-cli #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pensivebrian
requested changes
Aug 21, 2019
pensivebrian
requested changes
Aug 21, 2019
geleems
force-pushed
the
gelee/loc
branch
2 times, most recently
from
c278bc4 to
fe9633f
Compare
|
The are some strings that need to be translated in main.py |
|
Same with mssql_cli.py. Are you planning on making a complete loc string pass in another PR? |
|
Is it possible to add a unit test to make sure all of this works? |
|
Unit test for testing localization is added. |
pensivebrian
requested changes
Aug 28, 2019
pensivebrian
requested changes
Aug 29, 2019
pensivebrian
requested changes
Aug 30, 2019
pensivebrian
approved these changes
Aug 30, 2019
| @@ -120,8 +120,7 @@ def create_parser(): | |||
| dest=u'multi_subnet_failover', | |||
| action=u'store_true', | |||
| default=False, | |||
| help=u'If application is connecting to AlwaysOn AG on different subnets, setting this provides faster ' | |||
| u'detection and connection to currently active server.') | |||
| help=u'If application is connecting to AlwaysOn AG on different subnets, setting this provides faster detection and connection to currently active server.') | |||
There was a problem hiding this comment.
Let's revert this change as it's not related to loc.
|
|
||
| ## Localized Strings | ||
| def goodbye(): | ||
| return _(u'Goodbye!') |
| @@ -169,6 +171,44 @@ def validate_actions(user_actions, valid_targets): | |||
| sys.exit(1) | |||
|
|
|||
|
|
|||
| def generate_mo(extraction_target_path, lang_name, trans_mappings, domain, localedir=None): | |||
There was a problem hiding this comment.
We should separate out the po and mo generation, but we can do this in another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added localization framework to mssql-cli.