Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Select statement with foreign language fails #278

Merged
merged 6 commits into from
Sep 10, 2019
Merged

Fix: Select statement with foreign language fails #278

merged 6 commits into from
Sep 10, 2019

Conversation

geleems
Copy link

@geleems geleems commented Sep 9, 2019

This fix resolves #277

@geleems geleems requested a review from pensivebrian September 9, 2019 20:38
@geleems geleems self-assigned this Sep 9, 2019
pensivebrian
pensivebrian requested changes Sep 9, 2019
View reviewed changes
Copy link
Member

@pensivebrian pensivebrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix looks good. Can you add a unit test for this?

@geleems
Copy link
Author

geleems commented Sep 9, 2019 •
edited by pensivebrian
Loading

@pensivebrian

Can you add a unit test for this?

Did you mean unit test for utility.encode() and utility.decode() methods? Or unit test for mssqlclient._generate_query_results_to_tuples()?

I can add unit tests for utility.encode() and utility.decode(), but have no idea how to create unit tests for mssqlclient._generate_query_results_to_tuples(), and probably need your help.
#Closed

@pensivebrian
Copy link
Member

pensivebrian commented Sep 9, 2019 •
edited
Loading

A unit test that prevents this bug in the future, so mssqlclient._generate_query_results_to_tuples() #Closed

@geleems
Copy link
Author

geleems commented Sep 10, 2019 •
edited by pensivebrian
Loading

@pensivebrian
I added unit test that prevents this bug. #Closed

@pensivebrian
Copy link
Member

pensivebrian commented Sep 10, 2019 •
edited
Loading

On a general note, we're having some instability in the nightly runs. If the cloud is having a bad day, a create database statement may fail with a command timeout, but the operation may be in-progress. We should check the server sys.dm_operation_status DMV for the status of the create database operation, and poll until the create database operation completes. #Closed

pensivebrian
pensivebrian requested changes Sep 10, 2019
View reviewed changes
Copy link
Member

@pensivebrian pensivebrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still think we should go the temporary table route if possible.

pensivebrian
pensivebrian approved these changes Sep 10, 2019
View reviewed changes
Copy link
Member

@pensivebrian pensivebrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@geleems geleems merged commit 833105d into master Sep 10, 2019
@geleems geleems deleted the gelee/uc branch September 18, 2019 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pensivebrian pensivebrian pensivebrian approved these changes

Assignees

@geleems geleems

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Select statement with foreign language fails
2 participants
@geleems @pensivebrian