Fix test_slash_l* to support non-en_US locales #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the tests to expect the current locale rather than `en_US`. While technically this isn't 100% guaranteed to be the same locale as the database is running on, I think we can reasonably assume that for the purpose of testing they are the same. Non-UTF-8 locales still are not supported but the other tests seem to be unable to handle them well anyway. Fixes dbcli#140
|
Damn, I knew this is going to happen — the Docker container is actually using a different locale than GHA environment. I'm going to try if I can set them to match. |
|
Thank you @mgorny. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the tests to expect the current locale rather than
en_US. While technically this isn't 100% guaranteed to be the same locale as the database is running on, I think we can reasonably assume that for the purpose of testing they are the same. Non-UTF-8 locales still are not supported but the other tests seem to be unable to handle them well anyway.Fixes #140
Checklist
changelog.rst.pip install pre-commit && pre-commit install), and ranblackon my code.