Disable usage of "%s" #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users can already use parameters with "$N". This makes it so that users do not need to escape "%" with "%%" when using named queries. See dbcli/pgcli#865.
|
The PR looks good. It is currently failing on a lint check. You can fix it with this command: You might have to |
|
Let me know if you'd like to do that, if not, I can fix it separately. |
|
Yep I'll do it; probably take me a day though, travelling home soon
…On Tue, May 15, 2018, 12:22 Amjith Ramanujam ***@***.***> wrote:
Let me know if you'd like to do that, if not, I can fix it separately.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#60 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAFiWGNRjU4amk2t_Imw2JbMumuOiiNrks5tywDXgaJpZM4T_vEj>
.
|
|
No worries. Safe travels.
:)
On Tue, May 15, 2018 at 12:35 PM Jason A. Ribeiro <notifications@github.com>
wrote:
… Yep I'll do it; probably take me a day though, travelling home soon
On Tue, May 15, 2018, 12:22 Amjith Ramanujam ***@***.***>
wrote:
> Let me know if you'd like to do that, if not, I can fix it separately.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#60 (comment)>, or
mute
> the thread
> <
https://github.com/notifications/unsubscribe-auth/AAFiWGNRjU4amk2t_Imw2JbMumuOiiNrks5tywDXgaJpZM4T_vEj
>
> .
>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#60 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AADAbLGKu0whPXUlo4-Idxf_YgdsyzzJks5tywPYgaJpZM4T_vEj>
.
|
|
Changes for pep8 should be included now |
Codecov Report
@@ Coverage Diff @@
## master #60 +/- ##
========================================
Coverage ? 53.4%
========================================
Files ? 6
Lines ? 955
Branches ? 0
========================================
Hits ? 510
Misses ? 445
Partials ? 0
Continue to review full report at Codecov.
|
jrib
pushed a commit
to jrib/pgcli.com
that referenced
this pull request
May 20, 2018
|
Very nice! I like that the error message is helpful. 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Users can already use parameters with "$N". This makes it so that users
do not need to escape "%" with "%%" when using named queries.
See dbcli/pgcli#865.
The documentation on the website will have to be updated; is that on git somewhere?
Checklist
changelog.rst.