Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split MySQL 5.6 and 5.7 support from 8.0 #46

Merged
merged 9 commits into from
Jan 3, 2021
Merged

Split MySQL 5.6 and 5.7 support from 8.0 #46

merged 9 commits into from
Jan 3, 2021

Conversation

dbeatty10
Copy link
Owner

@dbeatty10 dbeatty10 commented Jan 3, 2021 •
edited
Loading

resolves #42

Description

  • Upgrade code and tests to be dbt v0.19.0rc1-compatible
  • Split the mysql5 adapter from the original mysql adapter
  • Reinstate CTE for the adapter for MySQL 8.0
  • Enable Pipenv for local development
  • Remove references to the ODBC driver
  • Separate test specifications per MySQL version (and instructions for running tests)

Checklist

  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md with information about my change

@dbeatty10 dbeatty10 marked this pull request as ready for review January 3, 2021 19:28
@dbeatty10 dbeatty10 merged commit 3c92178 into dev/0.19.0 Jan 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Split MySQL 5.6 and 5.7 support from 8.0
2 participants
@dbeatty10 @dbeatty