v1.1.0

[cyberman54]

fix issue #19

[cyberman54]

@oliverbrandmueller ping

[FlorianLudwig]

This will break libpax_serialize_config / libpax_deserialize_config for reading existing configs as all fields after wifi_my_country are moved by two bytes.

I see two options:

1. release as breaking change

• to follow semantic versioning this should be 2.0.0 and not 1.0.2 to signal that it is a breaking change (to API as well as stored configs)
• increase CONFIG_MAJOR_VERSION

2. release with backwards-compatibility

• add a wifi_my_country_str (or similar) at the end of the struct and keep the uint8_t wifi_my_country
• if wifi_my_country_str is not set read wifi_my_country and convert to wifi_my_country_str
• reduce libpax_config_storage_t.reserved_end from 25 bytes to 22 to keep the size of libpax_config_storage_t constant
• increase CONFIG_MINOR_VERSION

[cyberman54]

I go for no 2. and added commit 0f6c9dc to keep backward compatibility.
@FlorianLudwig Please check, thanks!

[cyberman54]

Added a fix to solve issue #21

[lifezoned4]

the code LGTM but one of the unit test fails because the counting of the report intervals is not summing up to 6 in 6 sec (1 sec per report) for espidf env. I think this has to do with the espressif32@5.2.0 version bump. For now I would say we give the delay 10ms more in test/libpax_test_cases.cpp:125. I don't see any problem in the actually timing when looking at esp_timer_get_time values in between the reports. So I assume it is a problem with vTaskDelayUntil?

The arduino env works fine without any unit test change.

Perhaps Also bump the version in library.json to 1.1.0 so we can go for a release?

[cyberman54]

@lifezoned4 fixed it, thanks for pointing to the Vtaskdelay timer. I set it to 6010 now. Will try to find out what's the root cause here.

[cyberman54]

This PR should now be ready to merge.
/cc @lifezoned4

[cyberman54]

@oliverbrandmueller for this PR we need the Release 1.1.0, too.

[cyberman54]

@oliverbrandmueller Platformio library manager does not find v1.1.0, does it need a kick?

[cyberman54]

@FlorianLudwig @oliverbrandmueller We need a pio pkg publish for v1.1.0 of this lib by owner greyrook!

[lifezoned4]

Did a publish bump and it should be available now. @cyberman54

[cyberman54]

@lifezoned4 now it works in platformio, thanks.