Skip to content

Commit

Permalink
Explicitly require racc and ostruct.
Browse files Browse the repository at this point in the history
  • Loading branch information
dblock committed Nov 6, 2024
1 parent 56995cc commit b1abd46
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 5 deletions.
17 changes: 12 additions & 5 deletions .rubocop_todo.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# This configuration was generated by
# `rubocop --auto-gen-config`
# on 2023-08-05 13:32:37 UTC using RuboCop version 1.26.1.
# on 2024-11-06 16:01:45 UTC using RuboCop version 1.26.1.
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
Expand Down Expand Up @@ -81,14 +81,14 @@ Performance/StringInclude:
Exclude:
- 'lib/tasks/web.rake'

# Offense count: 8
# Offense count: 9
# This cop supports safe auto-correction (--auto-correct).
RSpec/ContextMethod:
Exclude:
- 'spec/slack/messages/formatting_spec.rb'
- 'spec/slack/web/api/mixins/users_spec.rb'

# Offense count: 82
# Offense count: 83
# Configuration parameters: Prefixes.
# Prefixes: when, with, without
RSpec/ContextWording:
Expand All @@ -99,13 +99,13 @@ RSpec/ContextWording:
RSpec/ExampleLength:
Max: 18

# Offense count: 19
# Offense count: 18
# Configuration parameters: Include, CustomTransform, IgnoreMethods, SpecSuffixOnly.
# Include: **/*_spec*rb*, **/spec/**/*
RSpec/FilePath:
Enabled: false

# Offense count: 70
# Offense count: 69
# Configuration parameters: .
# SupportedStyles: have_received, receive
RSpec/MessageSpies:
Expand Down Expand Up @@ -166,6 +166,13 @@ Rake/Desc:
Exclude:
- 'lib/tasks/git.rake'

# Offense count: 1
# Configuration parameters: EnforcedStyle, AllowModifiersOnSymbols.
# SupportedStyles: inline, group
Style/AccessModifierDeclarations:
Exclude:
- 'lib/slack/real_time/client.rb'

# Offense count: 4
# Configuration parameters: MaxUnannotatedPlaceholdersAllowed, IgnoredMethods.
# SupportedStyles: annotated, template, unannotated
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
### 2.4.1 (Next)

* [#525](https://github.com/slack-ruby/slack-ruby-client/pull/525): Exclude spec files from gem package - [@amatsuda](https://github.com/amatsuda).
* [#527](https://github.com/slack-ruby/slack-ruby-client/pull/527): Explicitly require `racc` and `ostruct` - [@dblock](https://github.com/dblock).
* Your contribution here.

### 2.4.0 (2024/07/14)
Expand Down
1 change: 1 addition & 0 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ group :test do
gem 'erubis'
gem 'faraday-typhoeus'
gem 'json-schema'
gem 'racc'
gem 'rake', '~> 13'
gem 'rspec'
gem 'rubocop', '1.26.1' # Lock to specific version to avoid breaking cops/changes
Expand Down
1 change: 1 addition & 0 deletions spec/spec_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

require 'rubygems'
require 'rspec'
require 'ostruct'
require 'timecop'

require 'simplecov'
Expand Down

0 comments on commit b1abd46

Please sign in to comment.