Refactor repo and service for DigitalObjects to increase performance
#2649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morpheus-87
approved these changes
Oct 27, 2023
…etSqlSelectAllFields`
left) by pushing retrieval of linked data and rendering file resources to the repo (using joins instead).
- identifiers of `CreationInfo` properties - identifiers of parent, parent's parent & parent's item - identifiers of item - parent gets all the "reduced Fields" - set `fileResourceType` of `renderingResources`
- new jdbi plugin (from dc-commons-jdbi) - in DigitalObjectRepo: use Set instead of List in `rowView.getColumn()`
- SubjectRepo: identifiers are retrieved as jsonb instead of compound type - `DbIdentifierMapper` only for arguments (no column mapper anymore)
daforster
force-pushed
the
full-wmid-object
branch
from
5e54064
to
b5ffc01
Compare
|
We're currently processing your upload. This comment will be updated when the results are available. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…and some other small refactorings to cleanup the code.
Furthermore this PR introduces repeatable SQL migrations. The filename starts with
R__(no version) and they are always executed by flyway if they are modified (and new ones too of course). Unmodified repeatable migrations are not executed.Depends on: