Fix jpeg cropping edge case #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TurboJpeg expects cropping regions to be multiples of the MCU size. In some cases it was possible that the cropping region was larger than the image due to rounding artifacts (less than one MCU). This MR checks if the resulting region would exceed the image and makes it one MCU width and/or height smaller if needed.
jbaiter
force-pushed
the
fix-region-adjustment
branch
from
dd32c99
to
1d43cb1
Compare
jbaiter
approved these changes
May 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TurboJpeg expects cropping regions to be multiples of the MCU size. In some cases it was possible that the cropping region was larger than the image due to rounding artifacts (less than one MCU). This MR checks if the resulting region would exceed the image and makes it one MCU width and/or height smaller if needed.
TODO: Is it necessary to adjust the
extraCroppingto make sure it will be inside the adjusted region?