New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make share providers a configurable list of keys #137

Open

barmintor wants to merge 1 commit into dbmdz:main from barmintor:config-providers

barmintor commented Sep 17, 2023

No description provided.


          make share providers a configurable list of keys

e7f8d84

Member

morpheus-87 commented Sep 18, 2023

Thank you very much for your contribution! Unfortunately his extension doesn't work for the following reasons:

the translation for the tooltip wouldn't be defined for an unknown provider
the mapping for the icon has no entry for an unknown provider which causes an error during rendering (https://github.com/dbmdz/mirador-canvaslink/blob/main/src/components/dialog/ShareButton.jsx#L44)
the function defining the share links is also hardcoded for the known providers

Do you see any chance to fix these points? 🤔

Author

barmintor commented Sep 18, 2023

Three paths forward:

Social media links are a boolean switch in configuration - yes or no
Provider keys are an enumeration of known values
Provider is an API

Which do you think is right? (1) and (3) are not mutually exclusive, but (2) and (3) have different API expectations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet