Add parameters to startWorkflow #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraftp
approved these changes
Dec 11, 2024
kraftp
reviewed
Dec 11, 2024
kraftp
reviewed
Dec 11, 2024
| @@ -121,6 +121,11 @@ function httpApiDec(verb: APITypes, url: string) { | |||
| } | |||
| } | |||
|
|
|||
| export interface StartWorkflowParams { | |||
| workflowID?: string; | |||
| queueName?: string; | |||
There was a problem hiding this comment.
Maybe make it the entire queue object instead of just the name? Not a huge deal either way.
There was a problem hiding this comment.
There are reasons why not to use the whole object. Internally, we will eventually be able to get the object by name anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow setting of workflow ID and queue as part of startWorkflow syntax.
Remove a couple of comments that don't mean anything any more.