v2 API touchups #681
Merged
v2 API touchups #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraftp
reviewed
Dec 16, 2024
| @@ -1,6 +1,8 @@ | |||
| import { DBOS, WorkflowQueue } from '../src'; | |||
| import { generateDBOSTestConfig, setUpDBOSTestDb, TestKvTable } from './helpers'; | |||
|
|
|||
| DBOS.logger.info("This should not cause a kaboom."); | |||
There was a problem hiding this comment.
kraftp
reviewed
Dec 16, 2024
| @@ -565,6 +573,42 @@ export class DBOS { | |||
| static invoke<T extends ConfiguredInstance>(targetCfg: T): InvokeFuncsInst<T>; | |||
| static invoke<T extends object>(targetClass: T): InvokeFuncs<T>; | |||
| static invoke<T extends object>(object: T | ConfiguredInstance): InvokeFuncs<T> | InvokeFuncsInst<T> { | |||
| if (!DBOS.isWithinWorkflow()) { | |||
There was a problem hiding this comment.
What happens if you call a step normally outside a workflow, not using invoke? Does it work the same as in Python?
There was a problem hiding this comment.
Yeah that was true for a long time. This is about running a v1 step/transaction function without a HandlerContext.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were found during conversion of demo apps to v2: