Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cmd line interface #104

Merged
merged 7 commits into from
Oct 21, 2024
Merged

Conversation

kuefmz
Copy link
Collaborator

@kuefmz kuefmz commented Oct 21, 2024

Fixed these points:

  • add missing cmd params for host and port. note that it must be possible to define multiple hosts sucht that time machine can listen on multiple hosts/interfaces .default hosts are 0.0.0.0 and :: and port is 8898
  • configure such that default value for every paremeter is shown
  • add choices programmatically from enum as shown in the PR comment
  • logging parameter has no effect -> needs fixing

@kuefmz kuefmz mentioned this pull request Oct 21, 2024
6 tasks
@kuefmz
Copy link
Collaborator Author

kuefmz commented Oct 21, 2024

#92

@kuefmz
Copy link
Collaborator Author

kuefmz commented Oct 21, 2024

The help string would still need an explanation for all the possible choices.

parser = argparse.ArgumentParser(description="Process ontology format and version.")
parser = argparse.ArgumentParser(
description="Process ontology format and version.",
formatter_class=argparse.ArgumentDefaultsHelpFormatter,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also added this here, but it didn't add the default values to the help and the trick I did is also from the link you gave me :)

@JJ-Author JJ-Author merged commit 305d521 into dbpedia:main Oct 21, 2024
@JJ-Author JJ-Author mentioned this pull request Oct 21, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants