-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add large file upload support #33
Conversation
Hi @smk762 Thank you for your contribution! 👍🏻 I'll take a proper look and test myself as soon as I can 😃 |
Hi @smk762 I have reached out to VirusTotal support to see if they can grant my account with the access needed to test the equivilent v2 API endpoint. https://developers.virustotal.com/v2.0/reference/file-scan-upload-url |
VirusTotal support granted my account access to the v2 equivalent endpoint however, I've been unable to get it working. Every time I try to submit a file for analysis it returns a HTTP 500 internal server error. The v3 API endpoint worked without any issue 👍🏻 I will push the tests I've written later today 🙂 I might have to reach out to VirusTotal support (re: HTTP 500 error) however, its not to big of a deal as VirusTotal:
|
Add fixture `large_file_fixture` to setup and teardown a large file.
Add changelog for `0.2.0`.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi @smk762 Thank you so much for your contribution! ❤️ I have released |
Cheers mate, thanks for the credit and quick turnaround :) |
I noticed that while using this package on large files it wouldn't work as expected, and found the reason to be related to https://developers.virustotal.com/reference/files-upload-url
This PR will allow for large file upload by setting a boolean param
large_file
and using a generated large file upload URL as theresource
param.Example:
Real world example at https://github.com/smk762/draft_adex_release/blob/main/lib_virustotal.py#L26