Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.0.0 #39

Merged
merged 1 commit into from
May 13, 2024
Merged

Release v1.0.0 #39

merged 1 commit into from
May 13, 2024

Conversation

dbrgn
Copy link
Owner

@dbrgn dbrgn commented May 10, 2024

Now that embedded-hal 1.0 is out, we can tag 1.x as well.

@dbrgn dbrgn requested a review from rnestler May 10, 2024 18:59
@dbrgn dbrgn self-assigned this May 10, 2024
@dbrgn
Copy link
Owner Author

dbrgn commented May 10, 2024

@ShakenCodes @lightyear15 since you recently contributed to this library: Maybe you could quickly test whether the current main branch works without any issues for you, before I publish the release?

@ShakenCodes
Copy link
Contributor

@ShakenCodes @lightyear15 since you recently contributed to this library: Maybe you could quickly test whether the current main branch works without any issues for you, before I publish the release?

It has been tested with my hardware and passes our full automated test suite.

@elpiel
Copy link

elpiel commented May 11, 2024

Hey @dbrgn I was wondering if an async feature can be added to version 1.0 as well?

CHANGELOG.md Outdated Show resolved Hide resolved
@lightyear15
Copy link
Contributor

Hello @dbrgn

tested with my esp32-c3 devkit-rust board and it works as expected
thanks

@rnestler
Copy link
Collaborator

Hey @dbrgn I was wondering if an async feature can be added to version 1.0 as well?

I don't think it makes much sense to delay the 1.0 release with embedded-hal 1.0. If there is a PR adding async we can just release 1.1 or even 2.0 if it leads to breaking changes.

@dbrgn
Copy link
Owner Author

dbrgn commented May 13, 2024

Hey @dbrgn I was wondering if an async feature can be added to version 1.0 as well?

I don't think so, I'd prefer to push out the release soon, and I don't yet have any experience with async in the embedded context.

However, tagging 1.0.0 doesn't mean that async can't be added in a subsequent release. Depending on how it's implemented, it's not even a breaking change.

Edit: Oops, didn't see that @rnestler already replied as well 🙂

@dbrgn
Copy link
Owner Author

dbrgn commented May 13, 2024

@ShakenCodes @lightyear15 great, thanks for your testing!

@dbrgn dbrgn merged commit ee881d0 into main May 13, 2024
5 checks passed
@dbrgn dbrgn deleted the release-1.0.0 branch May 13, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants