-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v1.0.0 #39
Release v1.0.0 #39
Conversation
@ShakenCodes @lightyear15 since you recently contributed to this library: Maybe you could quickly test whether the current |
It has been tested with my hardware and passes our full automated test suite. |
Hey @dbrgn I was wondering if an async feature can be added to version 1.0 as well? |
Hello @dbrgn tested with my esp32-c3 devkit-rust board and it works as expected |
I don't think it makes much sense to delay the 1.0 release with embedded-hal 1.0. If there is a PR adding async we can just release 1.1 or even 2.0 if it leads to breaking changes. |
I don't think so, I'd prefer to push out the release soon, and I don't yet have any experience with async in the embedded context. However, tagging 1.0.0 doesn't mean that async can't be added in a subsequent release. Depending on how it's implemented, it's not even a breaking change. Edit: Oops, didn't see that @rnestler already replied as well 🙂 |
@ShakenCodes @lightyear15 great, thanks for your testing! |
Now that embedded-hal 1.0 is out, we can tag 1.x as well.