Fix clippy issues #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The result of running `cargo clippy --fix --all-targets --all-features` twice.
rnestler
force-pushed
the
fix-clippy-issues
branch
from
2a97315 to
a2f9295
Compare
warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used
--> examples/monitor-shtc3.rs:43:9
|
43 | for key in io::stdin().keys() {
| ^ ------------------ help: try: `io::stdin().keys().flatten()`
| _________|
| |
44 | | if let Ok(Key::Ctrl('c')) = key {
45 | | running.store(false, Ordering::SeqCst);
46 | | break;
47 | | }
48 | | }
| |_________^
|
help: ...and remove the `if let` statement in the for loop
--> examples/monitor-shtc3.rs:44:13
|
44 | / if let Ok(Key::Ctrl('c')) = key {
45 | | running.store(false, Ordering::SeqCst);
46 | | break;
47 | | }
| |_____________^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten
= note: `#[warn(clippy::manual_flatten)]` on by default
|
Thanks, LGTM! I think the two commits can be squashed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The result of running
cargo clippy --fix --all-targets --all-features.