Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the MinMaxSlider to display properly when inspector window is not in wide mode. #309

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Zxynine
Copy link

@Zxynine Zxynine commented Mar 16, 2022

Because the min max slider is based on a vector2, the display for it works the same. Vector2s will show on the same line in the inspector as the label only if the inspector is in widemode, otherwise, the height will double to allow the vector to be displayed on a line separate from the label. These changes just account for that and ensure it is displayed properly.

I typically keep my inspector as small as possible so the bug was really frustrating, I thought it was broken for the longest time until I saw this post : https://stackoverflow.com/questions/54814067/how-to-make-vector3-fields-behave-like-the-ones-from-transform-in-a-customeditor

Because the min max slider is based on a vector2, the display for it works the same. Vector2s will show on the same line in the inspector as the tag only if the inspector is in widemode, otherwise, the width will double to allow the vector to be displayed on a line separate from the label. These changes just account for that and ensure it is displayed properly.

I typically keep my inspector as small as possible so the bug was really frustrating, I thought it was broken for the longest time until I saw this post : https://stackoverflow.com/questions/54814067/how-to-make-vector3-fields-behave-like-the-ones-from-transform-in-a-customeditor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant