Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust __post_serialize__ signature #197

Merged
merged 3 commits into from
May 7, 2024
Merged

Adjust __post_serialize__ signature #197

merged 3 commits into from
May 7, 2024

Conversation

gshank
Copy link
Contributor

@gshank gshank commented May 6, 2024

resolves #198

In support of serialization context, for dbt-core #10093.

Problem

The method signature of __post_serialize__ is changing to support serialization context.

Solution

We're adding the "context" keyword parameter to __post_serialize__.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development, and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX

@gshank gshank merged commit 73e122d into main May 7, 2024
15 checks passed
@gshank gshank deleted the streaming_serialization branch May 7, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable serialization contexts
2 participants