Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Behavior Flag Framework #282

Merged
merged 20 commits into from
Sep 6, 2024
Merged

Add Behavior Flag Framework #282

merged 20 commits into from
Sep 6, 2024

Conversation

mikealfare
Copy link
Contributor

@mikealfare mikealfare commented Aug 13, 2024 •
edited
Loading

resolves #281

Problem

Add the Behavior Flag Framework from dbt-common.

Solution

Setup an empty collection of behavior flags and load them into the base adapter.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development, and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare requested a review from a team as a code owner August 13, 2024 00:21
@cla-bot cla-bot bot added the cla:yes label Aug 13, 2024
@github-actions GitHub Actions
Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@mikealfare mikealfare marked this pull request as draft August 24, 2024 00:47
mikealfare
mikealfare commented Sep 4, 2024
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
@mikealfare mikealfare marked this pull request as ready for review September 4, 2024 23:29
colin-rogers-dbt
colin-rogers-dbt reviewed Sep 5, 2024
View reviewed changes
Copy link
Contributor

@colin-rogers-dbt colin-rogers-dbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly fine just a couple questions

dbt/adapters/base/impl.py Outdated Show resolved Hide resolved
dbt/adapters/base/impl.py Show resolved Hide resolved
mikealfare
mikealfare commented Sep 5, 2024
View reviewed changes
tests/unit/conftest.py Outdated Show resolved Hide resolved
@mikealfare mikealfare self-assigned this Sep 6, 2024
@mikealfare mikealfare merged commit 8a570fa into main Sep 6, 2024
15 checks passed
@mikealfare mikealfare deleted the behavior-flags branch September 6, 2024 20:24
@colin-rogers-dbt colin-rogers-dbt mentioned this pull request Sep 10, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-rogers-dbt colin-rogers-dbt colin-rogers-dbt approved these changes

Assignees

@mikealfare mikealfare

Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Behavior Flags] Add Behavior Flag Framework to dbt-adapters
2 participants
@mikealfare @colin-rogers-dbt