-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EventTimeFilter and BaseRelation.render_event_time_filtered #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
MichelleArk
commented
Sep 4, 2024
MichelleArk
force-pushed
the
event-time-ref-filtering
branch
from
September 5, 2024 19:54
826d4c9
to
ee51afc
Compare
MichelleArk
commented
Sep 6, 2024
mikealfare
approved these changes
Sep 9, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #294
EventTimeFilter
class, which contains properties necessary to render a where filter on a given event time fieldBaseRelation
has an optionalEventTimeFilter
attributeBaseRelation.__str__
rendersEventTimeFilter
, if present to wrap the ref call in aselect * from ... where event_time >= lower_bound and event_time < upper_bound
limit
also provided, resolve limit first before event-time filter to prioritize performance of input data scansPostgres testing: https://github.com/dbt-labs/dbt-postgres/actions/runs/10775130606