Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Cleanup Python models section of README #643

Merged
merged 4 commits into from
May 10, 2024

Conversation

dfsnow
Copy link
Contributor

@dfsnow dfsnow commented May 7, 2024

Description

This PR adds a few of the limitations I found while trying to implement a Python model. It also cleans up some language in the docs and puts the sections in the correct order.

For reference, I have a Python model implementation here: ccao-data/data-architecture#422.

Checklist

  • You followed contributing section
  • You kept your Pull Request small and focused on a single feature or bug fix.
  • You added unit testing when necessary
  • You added functional testing when necessary

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
@dfsnow dfsnow changed the title Cleanup Python section of README Cleanup Python models section of README May 7, 2024
@dfsnow dfsnow changed the title Cleanup Python models section of README docs: Cleanup Python models section of README May 7, 2024
@dfsnow dfsnow marked this pull request as ready for review May 7, 2024 22:02
@nicor88
Copy link
Contributor

nicor88 commented May 8, 2024

@dfsnow Could you please fix the linting issue on the markdown? 🙏🏻

@dfsnow
Copy link
Contributor Author

dfsnow commented May 8, 2024

@dfsnow Could you please fix the linting issue on the markdown? 🙏🏻

@nicor88 Done!

README.md Show resolved Hide resolved
@nicor88 nicor88 merged commit 59d005a into dbt-labs:main May 10, 2024
9 checks passed
kodiakhq bot referenced this pull request in cloudquery/policies Jun 5, 2024
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [dbt-athena-community](https://github.com/dbt-athena/dbt-athena) | minor | `==1.7.2` -> `==1.8.2` |

---

### Release Notes

<details>
<summary>dbt-athena/dbt-athena (dbt-athena-community)</summary>

### [`v1.8.2`](https://github.com/dbt-athena/dbt-athena/releases/tag/v1.8.2)

[Compare Source](https://github.com/dbt-athena/dbt-athena/compare/v1.8.1...v1.8.2)

### What's Changed

#### Fixes

-   fix: Add wait_random_exponential for query retries by [@&#8203;svdimchenko](https://github.com/svdimchenko) in [https://github.com/dbt-athena/dbt-athena/pull/655](https://github.com/dbt-athena/dbt-athena/pull/655)
-   fix: Resolve error when cloning Python models ([#&#8203;645](https://github.com/dbt-athena/dbt-athena/issues/645)) by [@&#8203;jeancochrane](https://github.com/jeancochrane) in [https://github.com/dbt-athena/dbt-athena/pull/651](https://github.com/dbt-athena/dbt-athena/pull/651)
-   fix: Fixed table_type for GOVERNED tables by [@&#8203;svdimchenko](https://github.com/svdimchenko) in [https://github.com/dbt-athena/dbt-athena/pull/661](https://github.com/dbt-athena/dbt-athena/pull/661)

#### Features

-   feat: Set unique table suffix to allow parallel incremental executions by [@&#8203;pierrebzl](https://github.com/pierrebzl) in [https://github.com/dbt-athena/dbt-athena/pull/650](https://github.com/dbt-athena/dbt-athena/pull/650)
-   feat: Allow custom schema def for tmp tables generated by incremental by [@&#8203;pierrebzl](https://github.com/pierrebzl) in [https://github.com/dbt-athena/dbt-athena/pull/659](https://github.com/dbt-athena/dbt-athena/pull/659)
-   feat: Implement iceberg retry logic by [@&#8203;svdimchenko](https://github.com/svdimchenko) in [https://github.com/dbt-athena/dbt-athena/pull/657](https://github.com/dbt-athena/dbt-athena/pull/657)

#### Dependencies

-   chore: Update moto requirement from ~=5.0.7 to ~=5.0.8 by [@&#8203;dependabot](https://github.com/dependabot) in [https://github.com/dbt-athena/dbt-athena/pull/660](https://github.com/dbt-athena/dbt-athena/pull/660)
-   chore: Bumped version to 1.8.2 for release by [@&#8203;svdimchenko](https://github.com/svdimchenko) in [https://github.com/dbt-athena/dbt-athena/pull/663](https://github.com/dbt-athena/dbt-athena/pull/663)

#### Docs

-   docs: Cleanup README grammar, punctuation, and capitalisation by [@&#8203;dfsnow](https://github.com/dfsnow) in [https://github.com/dbt-athena/dbt-athena/pull/654](https://github.com/dbt-athena/dbt-athena/pull/654)

#### New Contributors

-   [@&#8203;jeancochrane](https://github.com/jeancochrane) made their first contribution in [https://github.com/dbt-athena/dbt-athena/pull/651](https://github.com/dbt-athena/dbt-athena/pull/651)
-   [@&#8203;pierrebzl](https://github.com/pierrebzl) made their first contribution in [https://github.com/dbt-athena/dbt-athena/pull/650](https://github.com/dbt-athena/dbt-athena/pull/650)

**Full Changelog**: dbt-labs/dbt-athena@v1.8.1...v1.8.2

### [`v1.8.1`](https://github.com/dbt-athena/dbt-athena/releases/tag/v1.8.1)

[Compare Source](https://github.com/dbt-athena/dbt-athena/compare/v1.7.2...v1.8.1)

#### What's Changed

##### Relevant notes

⚠️ 1.8.1 version is equivalent to 1.8.0 in term of features and fixes.

You can install the changes from this release via

    pip install dbt-athena-community==1.8.1

##### Features

-   feat: Add column meta to glue column parameters by [@&#8203;SoumayaMauthoorMOJ](https://github.com/SoumayaMauthoorMOJ) in [https://github.com/dbt-athena/dbt-athena/pull/644](https://github.com/dbt-athena/dbt-athena/pull/644)

##### Dependencies

-   chore: Update moto requirement from ~=5.0.6 to ~=5.0.7 by [@&#8203;dependabot](https://github.com/dependabot) in [https://github.com/dbt-athena/dbt-athena/pull/648](https://github.com/dbt-athena/dbt-athena/pull/648)

##### Docs

-   docs: Cleanup Python models section of README by [@&#8203;dfsnow](https://github.com/dfsnow) in [https://github.com/dbt-athena/dbt-athena/pull/643](https://github.com/dbt-athena/dbt-athena/pull/643)

#### New Contributors

-   [@&#8203;dfsnow](https://github.com/dfsnow) made their first contribution in [https://github.com/dbt-athena/dbt-athena/pull/643](https://github.com/dbt-athena/dbt-athena/pull/643)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 4am on the first day of the month" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zODMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjM4My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJhdXRvbWVyZ2UiXX0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants