Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tests for --empty flag #1030

Merged
merged 3 commits into from
Dec 1, 2023
Merged

add tests for --empty flag #1030

merged 3 commits into from
Dec 1, 2023

Conversation

MichelleArk
Copy link
Contributor

@MichelleArk MichelleArk commented Nov 17, 2023 •
edited
Loading

resolves #1029
docs dbt-labs/docs.getdbt.com/# N/A

Problem

dbt-labs/dbt-core#8971 introduced a new --empty flag that required implementation changes to the BaseRelation.

Solution

Add tests in dbt-bigquery to ensure expected behaviour of the new --empty flag when running with dbt-bigquery.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@cla-bot cla-bot bot added the cla:yes label Nov 17, 2023
MichelleArk
MichelleArk commented Nov 19, 2023
View reviewed changes
dev-requirements.txt Outdated Show resolved Hide resolved
@MichelleArk MichelleArk marked this pull request as ready for review November 20, 2023 15:06
@MichelleArk MichelleArk requested a review from a team as a code owner November 20, 2023 15:06
@mikealfare mikealfare merged commit c489332 into main Dec 1, 2023
15 checks passed
@mikealfare mikealfare deleted the support-empty branch December 1, 2023 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikealfare mikealfare mikealfare approved these changes

@McKnight-42 McKnight-42 Awaiting requested review from McKnight-42 McKnight-42 is a code owner automatically assigned from dbt-labs/adapters

Assignees

@MichelleArk MichelleArk

Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ADAP-1035] [Tests] Add tests for --empty flag
2 participants
@MichelleArk @mikealfare