Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove keyfile from _connection_keys #1147

Merged
merged 2 commits into from
Mar 25, 2024
Merged

remove keyfile from _connection_keys #1147

merged 2 commits into from
Mar 25, 2024

Conversation

McKnight-42
Copy link
Contributor

resolves #1146
docs dbt-labs/docs.getdbt.com/#

Problem

the field keyfile could have an argument to be a quasi secret level like field that possibly should be removed from debug and being called in jinja

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@McKnight-42 McKnight-42 self-assigned this Mar 22, 2024
@cla-bot cla-bot bot added the cla:yes label Mar 22, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-bigquery contributing guide.

1 similar comment
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-bigquery contributing guide.

@McKnight-42 McKnight-42 marked this pull request as ready for review March 22, 2024 18:52
@McKnight-42 McKnight-42 changed the title remove kefile from _connection_keys removekeyfile from _connection_keys Mar 22, 2024
@McKnight-42 McKnight-42 changed the title removekeyfile from _connection_keys remove keyfile from _connection_keys Mar 22, 2024
@McKnight-42 McKnight-42 merged commit 955afbd into main Mar 25, 2024
42 checks passed
@McKnight-42 McKnight-42 deleted the mcknight/1146 branch March 25, 2024 17:32
github-actions bot pushed a commit that referenced this pull request Mar 25, 2024
* remove kefile from _connection_keys

* add changelog

(cherry picked from commit 955afbd)
github-actions bot pushed a commit that referenced this pull request Mar 25, 2024
* remove kefile from _connection_keys

* add changelog

(cherry picked from commit 955afbd)
colin-rogers-dbt pushed a commit that referenced this pull request Mar 25, 2024
* remove kefile from _connection_keys

* add changelog

(cherry picked from commit 955afbd)

Co-authored-by: Matthew McKnight <91097623+McKnight-42@users.noreply.github.com>
colin-rogers-dbt pushed a commit that referenced this pull request Mar 25, 2024
* remove kefile from _connection_keys

* add changelog

(cherry picked from commit 955afbd)

Co-authored-by: Matthew McKnight <91097623+McKnight-42@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Remove keyfile from BigQueryCredentials._connection_keys
2 participants